Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1138853003: Create ChangeNotice(s) and set parsed/resolved units. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Create ChangeNotice(s) and set parsed/resolved units. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -47 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 16 chunks +29 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 5 chunks +40 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-12 02:32:11 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-12 13:46:28 UTC) #2
scheglov
5 years, 7 months ago (2015-05-12 13:52:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698