Rename CONSTANT_RESOLVED_UNIT to RESOLVED_UNIT.

Rename CONSTANT_RESOLVED_UNIT to RESOLVED_UNIT.

And move the old RESOLVED_UNIT out of the public API and rename it to
RESOLVED_UNIT6.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45777

[Paul Berry, 2015-05-11 22:45:40]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Paul Berry, 2015-05-11 22:45:41]

I just did this as a mechanical rename.  Probably some of the references to
RESOLVED_UNIT6 should actually be switched back to RESOLVED_UNIT (since they
require the results of constant evaluation), but I'm not sure which ones.  Feel
free to comment on this CL if you see some.  Otherwise we can make corrections
in future CL's.

[scheglov, 2015-05-11 23:58:30]

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:1151: new
LibrarySpecificUnit(librarySource, unitSource), RESOLVED_UNIT6);
I think we should return RESOLVED_UNIT from AnalysisContext.

[scheglov, 2015-05-12 00:26:04]

On 2015/05/11 23:58:30, scheglov wrote:
>
https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
> File pkg/analyzer/lib/src/context/context.dart (right):
> 
>
https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
> pkg/analyzer/lib/src/context/context.dart:1151: new
> LibrarySpecificUnit(librarySource, unitSource), RESOLVED_UNIT6);
> I think we should return RESOLVED_UNIT from AnalysisContext.

Also, currently we think that all the work is done for a library, when all its
errors are computed.
With this change errors might be computed, but the unit is not fully resolved
yet.
Maybe we should just do a much smaller change - replace RESOLVED_UNIT dependency
in constant evaluation with RESOLVED_UNIT6, produce RESOLVED_UNIT, and let all
the other clients to use RESOLVED_UNIT as they do now.

[Brian Wilkerson, 2015-05-12 00:43:23]

LGTM

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:606: CacheState state =
entry.getState(RESOLVED_UNIT6);
These two uses need to remain RESOLVED_UNIT.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:652: CompilationUnit unit =
_cache.getValue(target, RESOLVED_UNIT6);
I'm fairly confident that these three uses need to remain RESOLVED_UNIT.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:944: new
LibrarySpecificUnit(librarySource, unitSource), RESOLVED_UNIT6);
This needs to remain RESOLVED_UNIT.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:1114: entry.setState(RESOLVED_UNIT6,
CacheState.FLUSHED);
This needs to remain RESOLVED_UNIT, with RESOLVED_UNIT6 being added to the end
of the list.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:1151: new
LibrarySpecificUnit(librarySource, unitSource), RESOLVED_UNIT6);
Yes, this needs to remain RESOLVED_UNIT.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:1508: state =
unitEntry.getState(RESOLVED_UNIT6);
This needs to remain RESOLVED_UNIT.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2362: RESOLVED_UNIT_INPUT:
RESOLVED_UNIT6.of(target),
I'm fairly sure that this needs to remain RESOLVED_UNIT.

https://codereview.chromium.org/1138853002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3128: return <String, TaskInput>{UNIT_INPUT:
RESOLVED_UNIT6.of(target)};
I'm fairly sure that this needs to remain RESOLVED_UNIT.

[Paul Berry, 2015-05-13 20:41:22]

Committed patchset #2 (id:20001) manually as 45777 (presubmit successful).