Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 113833002: Add num.sign getter. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse, sra1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Changed to return same type as the number (double for doubles, int for ints). Returns -0.0 for -0.0… #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -1 line) Patch
M runtime/lib/double.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/lib/integers.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_number.dart View 1 2 chunks +3 lines, -1 line 3 comments Download
M sdk/lib/core/double.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/core/int.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/core/num.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
A tests/corelib/num_sign_test.dart View 1 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-12-13 11:24:30 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/113833002/diff/20001/sdk/lib/_internal/lib/js_number.dart File sdk/lib/_internal/lib/js_number.dart (right): https://codereview.chromium.org/113833002/diff/20001/sdk/lib/_internal/lib/js_number.dart#newcode62 sdk/lib/_internal/lib/js_number.dart:62: num get sign => this > 0 ? ...
7 years ago (2013-12-13 11:45:04 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/113833002/diff/20001/sdk/lib/_internal/lib/js_number.dart File sdk/lib/_internal/lib/js_number.dart (right): https://codereview.chromium.org/113833002/diff/20001/sdk/lib/_internal/lib/js_number.dart#newcode62 sdk/lib/_internal/lib/js_number.dart:62: num get sign => this > 0 ? 1 ...
7 years ago (2013-12-13 12:08:47 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 manually as r31126 (presubmit successful).
7 years ago (2013-12-13 12:10:37 UTC) #4
sra1
6 years, 9 months ago (2014-03-07 00:53:34 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/113833002/diff/20001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_number.dart (right):

https://codereview.chromium.org/113833002/diff/20001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_number.dart:245: if (false)
_shrReceiverPositive(other);
What is the purpose of this dead code?
Please delete it or explain it.

Powered by Google App Engine
This is Rietveld 408576698