Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 11381003: Create wrappers for MacOS/Linux to allow sdk "binaries" to be (Closed)

Created:
8 years, 1 month ago by dgrove
Modified:
8 years, 1 month ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create wrappers for MacOS/Linux to allow sdk "binaries" to be run from the repo. Committed: https://code.google.com/p/dart/source/detail?r=14764

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A sdk/bin/dart View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A sdk/bin/dart2js View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A sdk/bin/dartdoc View 2 1 chunk +26 lines, -0 lines 0 comments Download
A sdk/bin/pub View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgrove
8 years, 1 month ago (2012-11-07 20:57:19 UTC) #1
Ivan Posva
https://codereview.chromium.org/11381003/diff/2001/sdk/bin/dart2js File sdk/bin/dart2js (right): https://codereview.chromium.org/11381003/diff/2001/sdk/bin/dart2js#newcode31 sdk/bin/dart2js:31: exec "$BIN_DIR"/dart --no_use_inlining --heap_growth_rate=32 "$CUR_DIR/../lib/_internal/compiler/implementation/dart2js.dart" $COLORS "$@" How do ...
8 years, 1 month ago (2012-11-08 08:59:51 UTC) #2
dgrove
On 2012/11/08 08:59:51, Ivan Posva wrote: > https://codereview.chromium.org/11381003/diff/2001/sdk/bin/dart2js > File sdk/bin/dart2js (right): > > https://codereview.chromium.org/11381003/diff/2001/sdk/bin/dart2js#newcode31 ...
8 years, 1 month ago (2012-11-08 16:16:38 UTC) #3
dgrove
ptal. dart2js and dartdoc are now identical to what's in xcodebuild/ReleaseIA32/dart-sdk/bin pub matches what it ...
8 years, 1 month ago (2012-11-08 16:24:28 UTC) #4
ahe
Sorry I haven't responded yet. What I have seen so far makes perfect sense. I'll ...
8 years, 1 month ago (2012-11-08 16:45:13 UTC) #5
Ivan Posva
LGTM -ip https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart File sdk/bin/dart (right): https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart#newcode8 sdk/bin/dart:8: CUR_DIR="$(cd "${0%/*}" ; pwd -P)" Empty line ...
8 years, 1 month ago (2012-11-08 19:26:05 UTC) #6
ahe
LGTM, thanks, Dan! https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart File sdk/bin/dart (right): https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart#newcode9 sdk/bin/dart:9: if [ -z "$DART_VERSION" ]; On ...
8 years, 1 month ago (2012-11-09 16:37:05 UTC) #7
dgrove
8 years, 1 month ago (2012-11-09 23:04:30 UTC) #8
https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart
File sdk/bin/dart (right):

https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart#newcode8
sdk/bin/dart:8: CUR_DIR="$(cd "${0%/*}" ; pwd -P)"
On 2012/11/08 19:26:05, Ivan Posva wrote:
> Empty line between figuring out the current directory and determining the
> version?

Done.

https://codereview.chromium.org/11381003/diff/8001/sdk/bin/dart#newcode9
sdk/bin/dart:9: if [ -z "$DART_VERSION" ];
On 2012/11/09 16:37:05, ahe wrote:
> On 2012/11/08 19:26:05, Ivan Posva wrote:
> > Unfortunately I have no better suggestion than a environment variable right
> now.
> 
> DART_CONFIGURATION?

I went with DART_CONFIGURATION.

Powered by Google App Engine
This is Rietveld 408576698