Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1138083003: - Add --trace-loading to trace resolution and loading. (Closed)

Created:
5 years, 7 months ago by Ivan Posva
Modified:
5 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Add --trace-loading to trace resolution and loading. - Remove unused --print-script option. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -134 lines) Patch
M runtime/bin/builtin.dart View 18 chunks +42 lines, -40 lines 0 comments Download
M runtime/bin/dartutils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/dartutils.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 7 chunks +50 lines, -86 lines 0 comments Download
M runtime/bin/vmservice_dartium.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
5 years, 7 months ago (2015-05-11 22:20:00 UTC) #2
siva
PrintUsage needs to be updated. LGTM otherwise.
5 years, 7 months ago (2015-05-11 22:31:04 UTC) #3
Ivan Posva
Committed patchset #1 (id:1) manually as r45720 (presubmit successful).
5 years, 7 months ago (2015-05-11 22:58:44 UTC) #4
siva
5 years, 7 months ago (2015-05-12 15:38:31 UTC) #5
Message was sent while issue was closed.
Did you upload the updated version?
It looks like PrintUsage still shows the old message.

Powered by Google App Engine
This is Rietveld 408576698