Add a task for computing all constant values in a compilation unit.

Add a task for computing all constant values in a compilation unit.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45719

[Paul Berry, 2015-05-11 20:39:35]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-05-11 20:48:45]

LGTM

https://codereview.chromium.org/1137873003/diff/1/pkg/analyzer/lib/task/dart....
File pkg/analyzer/lib/task/dart.dart (right):

https://codereview.chromium.org/1137873003/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:118: * constants not yet resolved.
I have to wonder how many clients want an AST in which constants have not yet
been resolved.

It might be less confusing if RESOLVED_UNIT were renamed to RESOLVED_UNIT5,
moved to the internal library, and CONSTANT_RESOLVED_UNIT were renamed to
RESOLVED_UNIT.

[scheglov, 2015-05-11 20:51:43]

LGTM

[Paul Berry, 2015-05-11 22:07:39]

https://codereview.chromium.org/1137873003/diff/1/pkg/analyzer/lib/task/dart....
File pkg/analyzer/lib/task/dart.dart (right):

https://codereview.chromium.org/1137873003/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:118: * constants not yet resolved.
On 2015/05/11 20:48:45, Brian Wilkerson wrote:
> I have to wonder how many clients want an AST in which constants have not yet
> been resolved.
> 
> It might be less confusing if RESOLVED_UNIT were renamed to RESOLVED_UNIT5,
> moved to the internal library, and CONSTANT_RESOLVED_UNIT were renamed to
> RESOLVED_UNIT.

Good point.  I will do this in a follow-up CL.

[Paul Berry, 2015-05-11 22:18:12]

Committed patchset #1 (id:1) manually as 45719 (presubmit successful).