Issue 1137853002: - Refactor builtin.dart before any further work in this file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1137853002: - Refactor builtin.dart before any further work in this file. (Closed)

Created:
5 years, 7 months ago by Ivan Posva

Modified:
5 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Refactor builtin.dart before any further work in this file. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45669

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+212 lines, -167 lines)			Patch
M	runtime/bin/builtin.dart	View	12 chunks	+190 lines, -146 lines	1 comment	Download
M	runtime/bin/builtin_gen_snapshot.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/dartutils.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/bin/vmservice/loader.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

I am trying to separate the cleanup from the work on package spec and better ...

5 years, 7 months ago (2015-05-08 23:17:44 UTC) #2

siva

lgtm https://codereview.chromium.org/1137853002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/1137853002/diff/1/runtime/bin/builtin.dart#newcode10 runtime/bin/builtin.dart:10: // import 'root_library'; happens here from C Code ...

5 years, 7 months ago (2015-05-08 23:57:07 UTC) #3

Ivan Posva

5 years, 7 months ago (2015-05-08 23:58:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r45669 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages