Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 11377102: Remove named function literals from library and tests (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Remove named function literals from library and tests Start eliminating old-style function literals, i.e. remove return type and function names. Enforcing new style function literal syntax can be turned on with the vm flag --strict_function_literals. Committed: https://code.google.com/p/dart/source/detail?r=14805

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -338 lines) Patch
M runtime/vm/parser.cc View 1 2 3 chunks +71 lines, -31 lines 0 comments Download
M sdk/lib/core/map.dart View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/core/queue.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/set.dart View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/call_through_getter_test.dart View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language/function_argument_test.dart View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/function_literals2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/function_literals_test.dart View 1 2 2 chunks +3 lines, -76 lines 0 comments Download
M tests/language/function_syntax_test.dart View 1 2 6 chunks +29 lines, -110 lines 0 comments Download
M tests/language/function_test.dart View 1 2 4 chunks +0 lines, -48 lines 0 comments Download
M tests/language/function_type_alias6_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/function_type_alias_test.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/generic_syntax_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/generics_test.dart View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M tests/language/list_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/local_function2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/local_function_test.dart View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M tests/language/param2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/setter_no_getter_call_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
cc'ing Florian as an FYI due to library changes.
8 years, 1 month ago (2012-11-12 16:55:54 UTC) #1
srdjan
lgtm
8 years, 1 month ago (2012-11-12 19:43:05 UTC) #2
hausner
8 years, 1 month ago (2012-11-12 19:51:07 UTC) #3
tyvm

Powered by Google App Engine
This is Rietveld 408576698