Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 11377098: Change gyp flag from in_dartium to dart_io_support. (Closed)

Created:
8 years, 1 month ago by Bill Hesse
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change gyp flag from in_dartium to dart_io_support. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14842

Patch Set 1 #

Patch Set 2 : Remove intermediate nss_runtime target, and redundant dependencies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -38 lines) Patch
M runtime/bin/bin.gypi View 1 3 chunks +5 lines, -27 lines 0 comments Download
M runtime/bin/net/nss.gyp View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/net/sqlite.gyp View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/net/ssl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/net/zlib.gyp View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tools/gyp/runtime-configurations.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gyp/all.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gyp/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Also remove intermediate nss_runtime target, and redundant dependencies.
8 years, 1 month ago (2012-11-12 12:21:10 UTC) #1
Bill Hesse
Also remove intermediate nss_runtime target, and redundant dependencies.
8 years, 1 month ago (2012-11-12 12:21:54 UTC) #2
Mads Ager (google)
8 years, 1 month ago (2012-11-12 12:23:13 UTC) #3
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698