Issue 11377065: Re-included matchers documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11377065: Re-included matchers documentation. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski

Modified:
8 years, 1 month ago

Reviewers:
sethladd, gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-included matchers documentation. Committed: https://code.google.com/p/dart/source/detail?r=14710

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mock. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	utils/apidoc/apidoc.dart	View		3 chunks	+4 lines, -2 lines	0 comments	Download
	M	utils/apidoc/apidoc.gyp	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gram

See my comment - we need the mock library too. Else LGTM, thanks! https://codereview.chromium.org/11377065/diff/1/utils/apidoc/apidoc.gyp File ...

8 years, 1 month ago (2012-11-08 22:06:16 UTC) #2

Andrei Mouravski

8 years, 1 month ago (2012-11-08 22:07:32 UTC) #3

Thanks. Submitting.

https://codereview.chromium.org/11377065/diff/1/utils/apidoc/apidoc.gyp
File utils/apidoc/apidoc.gyp (right):

https://codereview.chromium.org/11377065/diff/1/utils/apidoc/apidoc.gyp#newco...
utils/apidoc/apidoc.gyp:46: '--include-lib=matcher',
On 2012/11/08 22:06:17, gram wrote:
> You need to add --include-lib=mock as well

Done.

Expand Messages | Collapse Messages