Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 11377039: Issue 6251. Resolve and rename type and constructor references in [new Type.name]. (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 6251. Resolve and rename type and constructor references in [new Type.name]. http://code.google.com/p/dart/issues/detail?id=6251 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -123 lines) Patch
M compiler/java/com/google/dart/compiler/ast/ASTVisitor.java View 1 chunk +8 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartComment.java View 5 chunks +31 lines, -9 lines 0 comments Download
A compiler/java/com/google/dart/compiler/ast/DartCommentNewName.java View 1 chunk +76 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/ast/DartCommentRefName.java View 1 chunk +49 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java View 2 chunks +39 lines, -15 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 3 chunks +29 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/ExternalTypeAnalyzers.java View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 5 chunks +46 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/NodeFinder.java View 3 chunks +10 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/contributor/IndexContributor.java View 22 chunks +96 lines, -68 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/search/SearchEngineImpl.java View 2 chunks +5 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java View 2 chunks +38 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/NameOccurrencesFinder.java View 2 chunks +18 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java View 1 chunk +30 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java View 2 chunks +11 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameLocalVariableProcessorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameMethodProcessorTest.java View 1 chunk +21 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameTypeProcessorTest.java View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 1 month ago (2012-11-07 22:09:11 UTC) #1
Brian Wilkerson
8 years, 1 month ago (2012-11-07 22:51:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698