Issue 11377025: Mark pkg/http/test/request_test flaky on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11377025: Mark pkg/http/test/request_test flaky on Windows (Closed)

Created:
8 years, 1 month ago by Søren Gjesse

Modified:
8 years, 1 month ago

Reviewers:
ahe, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark pkg/http/test/request_test flaky on Windows R=ager@google.com BUG=dart:6594 Committed: https://code.google.com/p/dart/source/detail?r=14624

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/pkg.status	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/11377025/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/11377025/diff/1/pkg/pkg.status#newcode59 pkg/pkg.status:59: pkg/http/test/request_test: Pass, Timeout # Issue 6594 I think you ...

8 years, 1 month ago (2012-11-07 15:21:29 UTC) #3

Søren Gjesse

8 years, 1 month ago (2012-11-07 15:25:17 UTC) #4

https://codereview.chromium.org/11377025/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/11377025/diff/1/pkg/pkg.status#newcode59
pkg/pkg.status:59: pkg/http/test/request_test: Pass, Timeout # Issue 6594
On 2012/11/07 15:21:30, ahe wrote:
> I think you need to remove pkg/.

Thanks for spotting this. Fixed in https://codereview.chromium.org/11364125/.

Expand Messages | Collapse Messages