Issue 113763004: Change Dart_GetNativeBooleanArgument to use class Ids and direct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113763004: Change Dart_GetNativeBooleanArgument to use class Ids and direct (Closed)

Created:
7 years ago by siva

Modified:
7 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change Dart_GetNativeBooleanArgument to use class Ids and direct pointer comparision of the singleton objects to determine value. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=31311

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -13 lines)			Patch
	M	runtime/vm/dart_api_impl.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+23 lines, -13 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmacnak

LGTM https://codereview.chromium.org/113763004/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (left): https://codereview.chromium.org/113763004/diff/20001/runtime/vm/dart_api_impl.cc#oldcode3869 runtime/vm/dart_api_impl.cc:3869: if (obj.IsNull()) { We've been interpreting null as ...

7 years ago (2013-12-19 19:36:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31311 (presubmit successful).

Expand Messages | Collapse Messages