Issue 113743003: Add more functions to the list of leaf functions which do not need an

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113743003: Add more functions to the list of leaf functions which do not need an (Closed)

Created:
6 years, 11 months ago by siva

Modified:
6 years, 11 months ago

Reviewers:
vsm, rmacnak

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add more functions to the list of leaf functions which do not need an auto generated dart scope. Resulting improvements in the Dromaeo benchmarks getAttribute 1072.0 1529.0 element_property_access 1304.0 1987.0 setAttribute 305.38922155688624 422.1556886227545 element_property_assignment 509.4905094905095 668.0 getElementById 1012.0 1523.0 getElementById (not in document) 2440.0 3279.0 getElementsByTagName(div) 119232.0 155037.0 getElementsByTagName(p) 109280.0 148015.0 getElementsByTagName(a) 119869.0 156460.0 getElementsByTagName(*) 114050.0 146375.0 getElementsByTagName (not in document) 172848.0 238313.0 getElementsByName 1356.0 1724.0 getElementsByName (not in document) 2657.0 2891.0 R=rmacnak@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=31582

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -41 lines)			Patch
M	tools/dom/scripts/generator.py	View	6 chunks	+20 lines, -12 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	20 chunks	+60 lines, -27 lines	0 comments	Download
M	tools/dom/templates/html/dartium/cpp_header.template	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

6 years, 11 months ago (2014-01-07 21:48:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r31582 (presubmit successful).

Expand Messages | Collapse Messages