Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 113733002: move contents of readme into library docs (Closed)

Created:
7 years ago by sethladd
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

move contents of readme into library docs BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=31104

Patch Set 1 #

Total comments: 8

Patch Set 2 : tweaks from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -35 lines) Patch
M pkg/http_server/README.md View 1 chunk +10 lines, -35 lines 0 comments Download
M pkg/http_server/lib/http_server.dart View 1 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sethladd
Hi Anders, I wanted to add a few docs for the http_server library API docs. ...
7 years ago (2013-12-12 07:02:09 UTC) #1
Anders Johnsen
LGTM, thanks Seth! :) https://codereview.chromium.org/113733002/diff/1/pkg/http_server/README.md File pkg/http_server/README.md (right): https://codereview.chromium.org/113733002/diff/1/pkg/http_server/README.md#newcode8 pkg/http_server/README.md:8: imports `dart:io`, it can use ...
7 years ago (2013-12-12 10:23:32 UTC) #2
sethladd
Thanks! Addressed your comments. https://codereview.chromium.org/113733002/diff/1/pkg/http_server/README.md File pkg/http_server/README.md (right): https://codereview.chromium.org/113733002/diff/1/pkg/http_server/README.md#newcode8 pkg/http_server/README.md:8: imports `dart:io`, it can use ...
7 years ago (2013-12-12 17:09:31 UTC) #3
sethladd
7 years ago (2013-12-12 17:12:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r31104 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698