Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1137313002: VM: Set breakpoints on x64 and arm64 without patching code. (Closed)

Created:
5 years, 7 months ago by Florian Schneider
Modified:
5 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Set breakpoints on x64 and arm64 without patching code. Instead of changing the generated code, change the target of calls by changing the corresponding entry in the constant pool. Patchable call sites can't share constant pool entries for now. x64 and arm64 already had support for patching call targets in the constant pool, but the debugger used to change the code instead. This eliminates the fixed debugger stub entries in every constant pool.

Patch Set 1 #

Patch Set 2 : re-upload from git workspace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -291 lines) Patch
M runtime/vm/assembler_arm64.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/code_patcher.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/code_patcher_arm.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/code_patcher_arm64.cc View 1 2 chunks +32 lines, -30 lines 0 comments Download
M runtime/vm/code_patcher_ia32.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/code_patcher_mips.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/code_patcher_x64.cc View 1 2 chunks +23 lines, -51 lines 0 comments Download
M runtime/vm/debugger_arm64.cc View 1 2 chunks +28 lines, -59 lines 0 comments Download
M runtime/vm/debugger_x64.cc View 1 2 chunks +28 lines, -60 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 7 months ago (2015-05-13 13:30:36 UTC) #2
hausner
LGTM. Extra points for removing more lines than adding new ones :)
5 years, 7 months ago (2015-05-13 23:53:54 UTC) #3
Florian Schneider
On 2015/05/13 23:53:54, hausner wrote: > LGTM. Extra points for removing more lines than adding ...
5 years, 7 months ago (2015-05-18 11:51:11 UTC) #4
Florian Schneider
5 years, 7 months ago (2015-05-18 13:03:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9191b76fd2d2567076c63066c0790e19522d98da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698