Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 113693003: dartfmt gets opinionated about 'gratuitous' linebreaks. (Closed)

Created:
7 years ago by pquitslund
Modified:
7 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dartfmt gets opinionated about 'gratuitous' linebreaks. IOW: we now collapse lines that are broken. NOTE: EOL comments are sure to break this; CL to address to follow. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31243

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 10 chunks +30 lines, -5 lines 2 comments Download
M pkg/analyzer/test/services/formatter_test.dart View 4 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
More babysteps... :) https://codereview.chromium.org/113693003/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart File pkg/analyzer/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/113693003/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart#newcode1324 pkg/analyzer/lib/src/services/formatter_impl.dart:1324: //TODO(pquitslund): handle this more neatly EG: ...
7 years ago (2013-12-18 17:16:47 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/113693003/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart File pkg/analyzer/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/113693003/diff/20001/pkg/analyzer/lib/src/services/formatter_impl.dart#newcode1324 pkg/analyzer/lib/src/services/formatter_impl.dart:1324: //TODO(pquitslund): handle this more neatly > EG: by ...
7 years ago (2013-12-18 17:53:07 UTC) #2
pquitslund
7 years ago (2013-12-18 22:57:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698