Issue 11369230: Enable inlining of functions containing instance-of.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369230: Enable inlining of functions containing instance-of. (Closed)

Created:
8 years, 1 month ago by Florian Schneider

Modified:
8 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enable inlining of functions containing instance-of. The corresponding issues have been fixed and all tests pass now. BUG=dart:5216, dart:5217 Committed: https://code.google.com/p/dart/source/detail?r=14872

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	runtime/vm/flow_graph_compiler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Hi Regis, I've noticed that you fixed the issues mentioned in this bailout. It should ...

8 years, 1 month ago (2012-11-13 22:47:36 UTC) #1

regis

8 years, 1 month ago (2012-11-13 23:23:29 UTC) #2

LGTM

But I am not sure what cl of mine you are referring to.

Expand Messages | Collapse Messages