Issue 11369158: Reland: Improve smi shift operations and avoid repeated deoptimizations.

Issue 11369158: Reland: Improve smi shift operations and avoid repeated deoptimizations. (Closed)

Created:
8 years, 1 month ago by Florian Schneider

Modified:
8 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reland: Improve smi shift operations and avoid repeated deoptimizations. This CL includes a bug fix where a NULL check of the pc was missing. Also change the dart2js test status of arithmetic_test from Skip to Fail. Committed: https://code.google.com/p/dart/source/detail?r=14755

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -106 lines)			Patch
M	runtime/vm/code_generator.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/deopt_instructions.h	View	4 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	4 chunks	+13 lines, -1 line	2 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	6 chunks	+26 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	4 chunks	+34 lines, -37 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	4 chunks	+35 lines, -37 lines	0 comments	Download
M	runtime/vm/object.h	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Fixed the crash bug and changed dart2js arithmetic_test expectations to Fail.

8 years, 1 month ago (2012-11-09 17:44:22 UTC) #1

srdjan

LGTM https://codereview.chromium.org/11369158/diff/1/runtime/vm/deopt_instructions.cc File runtime/vm/deopt_instructions.cc (right): https://codereview.chromium.org/11369158/diff/1/runtime/vm/deopt_instructions.cc#newcode264 runtime/vm/deopt_instructions.cc:264: if (pc != 0) { Maybe add a ...

8 years, 1 month ago (2012-11-09 17:53:54 UTC) #2

Florian Schneider

8 years, 1 month ago (2012-11-09 19:56:08 UTC) #3

https://codereview.chromium.org/11369158/diff/1/runtime/vm/deopt_instructions.cc
File runtime/vm/deopt_instructions.cc (right):

https://codereview.chromium.org/11369158/diff/1/runtime/vm/deopt_instructions...
runtime/vm/deopt_instructions.cc:264: if (pc != 0) {
On 2012/11/09 17:53:54, srdjan wrote:
> Maybe add a comment what is happening here, e.g.: if the deoptimization
occurred
> on an IC call, update the ICData ...

Done.

Expand Messages | Collapse Messages