Issue 11369152: Disable NSS build targets in a Dartium build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369152: Disable NSS build targets in a Dartium build. (Closed)

Created:
8 years, 1 month ago by Bill Hesse

Modified:
8 years, 1 month ago

Reviewers:
Anton Muhin, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable NSS build targets in a Dartium build. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14740

Patch Set 1 #

Patch Set 2 : Add comments, and modify zlib.gyp file that was missed. #

Patch Set 3 : Add comma, comment. #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -21 lines)			Patch
M	runtime/bin/bin.gypi	View		2 chunks	+22 lines, -20 lines	0 comments	Download
M	runtime/bin/net/nss.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/net/sqlite.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/net/ssl.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/net/zlib.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/dart-runtime.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/tools/gyp/runtime-configurations.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/gyp/all.gypi	View		1 chunk	+2 lines, -0 lines	1 comment	Download
M	tools/gyp/common.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 1 month ago (2012-11-12 07:27:41 UTC) #3

LGTM, but I think we should rename the condition.

http://codereview.chromium.org/11369152/diff/1010/tools/gyp/all.gypi
File tools/gyp/all.gypi (right):

http://codereview.chromium.org/11369152/diff/1010/tools/gyp/all.gypi#newcode15
tools/gyp/all.gypi:15: 'in_dartium': 0,
Maybe we should call this variable 'dart_io_support' (and flip the values). The
particular instance of the problem was Dartium, but the problem of not wanting
to build with dart_io support seems more general?

Expand Messages | Collapse Messages