Issue 11369066: Show better error messages in network failures.

Issue 11369066: Show better error messages in network failures. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom

Modified:
8 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Show better error messages in network failures. We had decent messages for a couple of failure modes. This tries to catch some more. Committed: https://code.google.com/p/dart/source/detail?r=14543

Patch Set 2 : Clean up string interpolation a bit. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -16 lines)			Patch
M	utils/pub/hosted_source.dart	View	1	3 chunks	+25 lines, -6 lines	0 comments	Download
M	utils/pub/io.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	utils/pub/package.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	utils/pub/source.dart	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	utils/tests/pub/install/hosted/fail_gracefully_on_missing_package_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/update/hosted/fail_gracefully_on_missing_package_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/version_solver_test.dart	View		4 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Tries to improve http://code.google.com/p/dart/issues/detail?id=5876

8 years, 1 month ago (2012-11-03 01:27:54 UTC) #1

nweiz

A couple suggestions, but lgtm https://codereview.chromium.org/11369066/diff/1/utils/pub/hosted_source.dart File utils/pub/hosted_source.dart (right): https://codereview.chromium.org/11369066/diff/1/utils/pub/hosted_source.dart#newcode127 utils/pub/hosted_source.dart:127: throw 'Could not find ...

8 years, 1 month ago (2012-11-05 19:55:36 UTC) #2

Bob Nystrom

8 years, 1 month ago (2012-11-05 20:43:06 UTC) #3

Thanks!

https://codereview.chromium.org/11369066/diff/1/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/11369066/diff/1/utils/pub/hosted_source.dart#...
utils/pub/hosted_source.dart:127: throw 'Could not find package "${package}" at
${url}.';
On 2012/11/05 19:55:36, nweiz wrote:
> Why "${package}" and "${url}" over "$package" and "$url"?

Done. There used to be more complex expressions in there, and I didn't remember
to ditch the curlies when I simplified them.

https://codereview.chromium.org/11369066/diff/1/utils/pub/package.dart
File utils/pub/package.dart (right):

https://codereview.chromium.org/11369066/diff/1/utils/pub/package.dart#newcod...
utils/pub/package.dart:142: return "$name $version from ${source.name}";
On 2012/11/05 19:55:36, nweiz wrote:
> While we're cleaning up toStrings, maybe add a default Source#toString that
> returns the source's name, and use that here?

Good idea. Done.

Expand Messages | Collapse Messages