Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136843006: dart2js cps: Access to lazily initialized fields. (Closed)

Created:
5 years, 7 months ago by asgerf
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Minor fix #

Total comments: 6

Patch Set 3 : Comments #

Patch Set 4 : Status files #

Patch Set 5 : Update analyzer2dart so tests don't fail #

Patch Set 6 : Status again #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -1471 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 4 chunks +12 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 3 chunks +16 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 3 4 5 11 chunks +68 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 4 chunks +27 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +17 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 1 chunk +11 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 14 chunks +22 lines, -1314 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 5 chunks +21 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 3 4 chunks +0 lines, -8 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 3 3 chunks +1 line, -4 lines 0 comments Download
M tests/html/html.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 19 chunks +0 lines, -51 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 6 6 chunks +1 line, -28 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 5 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
asgerf
5 years, 7 months ago (2015-05-13 13:32:56 UTC) #2
asgerf
Karl is on vacation. Adding R=kmillikin@google.com
5 years, 7 months ago (2015-05-18 12:10:30 UTC) #4
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/1136843006/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1136843006/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode3128 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3128: // Instance fields initializers are inlined in the ...
5 years, 7 months ago (2015-05-18 12:28:24 UTC) #5
asgerf
https://codereview.chromium.org/1136843006/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1136843006/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode3128 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3128: // Instance fields initializers are inlined in the constructor, ...
5 years, 7 months ago (2015-05-18 12:38:19 UTC) #6
asgerf
5 years, 7 months ago (2015-05-19 08:05:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
ccee558a5b03eeb9e66d706c53a5dc2d251938a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698