Take 2 of splitting html tests into subtests. Had to make two changes to drt to

Take 2 of splitting html tests into subtests. Had to make two changes to drt to
fully work.
Committed: https://code.google.com/p/dart/source/detail?r=14703

[Emily Fortuna, 2012-11-08 02:19:09]

This is identical to https://codereview.chromium.org//11293019 (which I
reverted) with a few exceptions: 
drt-trampoline.py was added

the two comments below show the two other changes (the reason I reverted was drt
was failing because it was trying to convert the # in the URL to %23. adding
file:// fixes that).

The meat of the CL is the same as what you reviewed before, though.

Siggi -- you need only look at the new changes in this CL.

https://codereview.chromium.org/11368128/diff/4001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11368128/diff/4001/tests/html/html.status#new...
tests/html/html.status:183: element_test/attributes: Fail, Crash
these safari failures are new for this CL -- because I couldn't test Safari 5 on
my computer since everywhere else but the bot has Safari 6

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:733: 'file://$htmlPath';
lines 732-733 are new (adding file://)

[Siggi Cherem (dart-lang), 2012-11-08 02:50:14]

the 2 new changes lgtm.

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:732: String fullHtmlPath =
htmlPath.startsWith('http:')? htmlPath:
nit: spacing - add space between )? and before :

[Bill Hesse, 2012-11-08 09:09:49]

LGTM.

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:732: String fullHtmlPath =
htmlPath.startsWith('http:')? htmlPath:
Seconded: spacing before ? and :.
On 2012/11/08 02:50:14, Siggi Cherem (dart-lang) wrote:
> nit: spacing - add space between )? and before :

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:733: 'file://$htmlPath';
This is really Resolve(htmlPath, "file://"), isn't it?  Which doesn't really
make sense because "file://" is not a complete URL.

It is too bad that our URL tools can't easily just do resolve htmlPath against
file:///, because that is what you want.

Should you add a test that htmlPath starts with / if it does not start with
http://

[Emily Fortuna, 2012-11-08 18:33:14]

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:732: String fullHtmlPath =
htmlPath.startsWith('http:')? htmlPath:
On 2012/11/08 09:09:49, Bill Hesse wrote:
> Seconded: spacing before ? and :.
> On 2012/11/08 02:50:14, Siggi Cherem (dart-lang) wrote:
> > nit: spacing - add space between )? and before :
> 

Done.

https://codereview.chromium.org/11368128/diff/4001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:733: 'file://$htmlPath';
We don't want to add a test that htmlPath starts with / if not http:// because
what about Windows paths? 

I'm not sure which/what Resolve() function you're talking about: this one?
http://api.dartlang.org/docs/bleeding_edge/dart_uri/Uri.html#resolve I couldn't
find one that takes two arguments

On 2012/11/08 09:09:49, Bill Hesse wrote:
> This is really Resolve(htmlPath, "file://"), isn't it?  Which doesn't really
> make sense because "file://" is not a complete URL.
> 
> It is too bad that our URL tools can't easily just do resolve htmlPath against
> file:///, because that is what you want.
> 
> Should you add a test that htmlPath starts with / if it does not start with
> http://