Issue 11368124: Fix library syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11368124: Fix library syntax (Closed)

Created:
8 years, 1 month ago by gram

Modified:
8 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix library syntax Committed: https://code.google.com/p/dart/source/detail?r=14701

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	runtime/bin/builtin.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/crypto/crypto_vm.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/utf/utf_vm.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/tests/vm/dart/byte_array_test.dart	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_remote_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/tests/vm/test_config.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 1 month ago (2012-11-08 18:38:19 UTC) #2

lgtm - I forgot to hit the button yesterday :(

https://codereview.chromium.org/11368124/diff/1/runtime/tests/vm/dart/byte_ar...
File runtime/tests/vm/dart/byte_array_test.dart (right):

https://codereview.chromium.org/11368124/diff/1/runtime/tests/vm/dart/byte_ar...
runtime/tests/vm/dart/byte_array_test.dart:6: library ByteArrayTest;
use lower_case_name to match the filename.

Expand Messages | Collapse Messages