Issue 11368101: Don't run compile time error tests on browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11368101: Don't run compile time error tests on browsers. (Closed)

Created:
8 years, 1 month ago by kustermann

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't run compile-time error tests on browsers. Also added a new category to the report stating the number of tests we skipped because of this. Committed: https://code.google.com/p/dart/source/detail?r=14571

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View	1 2	4 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11368101/diff/2001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/11368101/diff/2001/tools/testing/dart/test_suite.dart#newcode1498 tools/testing/dart/test_suite.dart:1498: * $compileErrorSkip tests are skipped on compile-time error ...

8 years, 1 month ago (2012-11-06 14:25:57 UTC) #2

kustermann

8 years, 1 month ago (2012-11-06 14:43:06 UTC) #3

https://codereview.chromium.org/11368101/diff/2001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11368101/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1498: * $compileErrorSkip tests are skipped
on compile-time error
On 2012/11/06 14:25:57, ahe wrote:
> "tests are skipped on browsers due to compile-time error"

Done.

Expand Messages | Collapse Messages