Issue 11367040: Removing Element.rect.

Issue 11367040: Removing Element.rect. (Closed)

Created:
8 years, 1 month ago by blois

Modified:
8 years, 1 month ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing Element.rect. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14720

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -377 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	6 chunks	+0 lines, -87 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	6 chunks	+0 lines, -87 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_DocumentFragment.darttemplate	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+0 lines, -51 lines	0 comments	Download
M	lib/html/templates/html/interface/interface_Element.darttemplate	View	2 chunks	+0 lines, -21 lines	0 comments	Download
M	samples/calculator/tape.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/clock/clock.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	samples/clock/numbers.dart	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	samples/dartcombat/views.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	samples/solar/solar.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	samples/swarm/Views.dart	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	samples/swipe/swipe.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	samples/tests/samples/lib/layout/grid_layout_demo.dart	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	samples/tests/samples/lib/layout/layout_test.dart	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	samples/ui_lib/layout/ViewLayout.dart	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	samples/ui_lib/touch/Scroller.dart	View	1 chunk	+8 lines, -17 lines	0 comments	Download
M	samples/ui_lib/view/PagedViews.dart	View	8 chunks	+18 lines, -22 lines	0 comments	Download
M	samples/ui_lib/view/SliderMenu.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	samples/ui_lib/view/view.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/documentfragment_test.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/html/element_test.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	tests/html/measurement_test.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/11367040/diff/1/samples/clock/clock.dart File samples/clock/clock.dart (left): https://codereview.chromium.org/11367040/diff/1/samples/clock/clock.dart#oldcode50 samples/clock/clock.dart:50: remove requestLayoutFrame as well as async getComputedStyles

8 years, 1 month ago (2012-11-02 05:00:29 UTC) #2

blois

8 years, 1 month ago (2012-11-02 20:04:46 UTC) #3

https://codereview.chromium.org/11367040/diff/1/samples/clock/clock.dart
File samples/clock/clock.dart (left):

https://codereview.chromium.org/11367040/diff/1/samples/clock/clock.dart#oldc...
samples/clock/clock.dart:50: 
On 2012/11/02 05:00:29, Jacob wrote:
> remove requestLayoutFrame as well as async getComputedStyles

Not sure which getComputedStyles you're referring to.

Expand Messages | Collapse Messages