Issue 11367007: Tests owed.

Issue 11367007: Tests owed. (Closed)

Created:
8 years, 1 month ago by ahe

Modified:
8 years, 1 month ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tests owed. BUG=http://dartbug.com/5829, http://dartbug.com/4444. Committed: https://code.google.com/p/dart/source/detail?r=14338

Patch Set 1 #

Total comments: 4

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -5 lines)			Patch
M	dart/tests/compiler/dart2js/parser_helper.dart	View	3 chunks	+10 lines, -5 lines	4 comments	Download
M	dart/tests/compiler/dart2js/parser_test.dart	View	2 chunks	+27 lines, -0 lines	0 comments	Download
A	dart/tests/language/super_assign_test.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

LGTM with comments https://codereview.chromium.org/11367007/diff/1/dart/tests/compiler/dart2js/parser_helper.dart File dart/tests/compiler/dart2js/parser_helper.dart (right): https://codereview.chromium.org/11367007/diff/1/dart/tests/compiler/dart2js/parser_helper.dart#newcode33 dart/tests/compiler/dart2js/parser_helper.dart:33: Node parseBodyCode(String text, Function parseMethod, {DiagnosticListener ...

8 years, 1 month ago (2012-10-31 12:24:22 UTC) #2

ahe

8 years, 1 month ago (2012-10-31 14:00:09 UTC) #4

Thank you for taking a look!

https://codereview.chromium.org/11367007/diff/1/dart/tests/compiler/dart2js/p...
File dart/tests/compiler/dart2js/parser_helper.dart (right):

https://codereview.chromium.org/11367007/diff/1/dart/tests/compiler/dart2js/p...
dart/tests/compiler/dart2js/parser_helper.dart:33: Node parseBodyCode(String
text, Function parseMethod, {DiagnosticListener lc}) {
On 2012/10/31 12:24:22, Johnni Winther wrote:
> Bad name. I can see from the code that it is an abbreviation of
LoggerCanceler,
> but I have no idea what that is either.

Done.

https://codereview.chromium.org/11367007/diff/1/dart/tests/compiler/dart2js/p...
dart/tests/compiler/dart2js/parser_helper.dart:62: Node parseMember(String text,
{DiagnosticListener lc}) =>
On 2012/10/31 12:24:22, Johnni Winther wrote:
> Also bad name here.

Done.

Expand Messages | Collapse Messages