Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1136673002: Progress toward new AnalysisContextImpl (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Progress toward new AnalysisContextImpl R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 4 chunks +42 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 7 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-07 22:53:33 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-07 23:09:19 UTC) #3
Brian Wilkerson
5 years, 7 months ago (2015-05-07 23:19:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698