Issue 11366169: Fix multiple onRequest callbacks during redirect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366169: Fix multiple onRequest callbacks during redirect. (Closed)

Created:
8 years, 1 month ago by Søren Gjesse

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix multiple onRequest callbacks during redirect. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14727

Patch Set 2 : Addressed review comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -3 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View		4 chunks	+9 lines, -3 lines	0 comments	Download
	M	tests/standalone/io/http_redirect_test.dart	View	1	3 chunks	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://codereview.chromium.org/11366169/diff/1/tests/standalone/io/http_redirect_test.dart File tests/standalone/io/http_redirect_test.dart (right): https://codereview.chromium.org/11366169/diff/1/tests/standalone/io/http_redirect_test.dart#newcode132 tests/standalone/io/http_redirect_test.dart:132: client.getUrl(new Uri.fromString("http://127.0.0.1:${server.port}/redirect")); Long line.

8 years, 1 month ago (2012-11-09 09:31:21 UTC) #2

Søren Gjesse

8 years, 1 month ago (2012-11-09 09:36:13 UTC) #3

https://codereview.chromium.org/11366169/diff/1/tests/standalone/io/http_redi...
File tests/standalone/io/http_redirect_test.dart (right):

https://codereview.chromium.org/11366169/diff/1/tests/standalone/io/http_redi...
tests/standalone/io/http_redirect_test.dart:132: client.getUrl(new
Uri.fromString("http://127.0.0.1:${server.port}/redirect"));
On 2012/11/09 09:31:21, Mads Ager wrote:
> Long line.

Done.

Expand Messages | Collapse Messages

Issue 11366169: Fix multiple onRequest callbacks during redirect. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages