Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 11366071: Throwing type check errors is very slow compared to other checks (e.g., value check error in typed … (Closed)

Created:
8 years, 1 month ago by srdjan
Modified:
8 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Throwing type check errors is very slow compared to other checks (e.g., value check error in typed arrays). Take those checks out of the loop, whihc is there only to force optimization. Committed: https://code.google.com/p/dart/source/detail?r=14503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M tests/standalone/byte_array_test.dart View 4 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
This fixes issue 6494
8 years, 1 month ago (2012-11-02 22:16:03 UTC) #1
regis
8 years, 1 month ago (2012-11-02 22:31:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698