Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 11366062: Use union type parts when check if type is subtype. (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use union type parts when check if type is subtype. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -121 lines) Patch
M compiler/java/com/google/dart/compiler/type/InterfaceTypeUnion.java View 1 chunk +6 lines, -100 lines 0 comments Download
A + compiler/java/com/google/dart/compiler/type/InterfaceTypeUnionImplementation.java View 4 chunks +16 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 4 chunks +4 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/Types.java View 3 chunks +14 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 1 month ago (2012-11-02 16:32:14 UTC) #1
Brian Wilkerson
8 years, 1 month ago (2012-11-02 17:11:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698