Update intl to new import syntax

Update intl to new import syntax
Committed: https://code.google.com/p/dart/source/detail?r=14372

[Alan Knight, 2012-10-31 19:53:15]

Not as large as it looks :-)

Just running the editor's migration tool for the import/library/part/part of
directives in the intl code.

[Emily Fortuna, 2012-10-31 20:17:32]

lgtm with a few adjustments/comments

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/bidi_utils.dart
File pkg/intl/lib/bidi_utils.dart (right):

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/bidi_utils.dart#...
pkg/intl/lib/bidi_utils.dart:362: if (char == '('.charCodeAt(0)) { sum++;
adding brackets here while sum++ is still on the same line as the if strikes me
as odd. I'd say do one or the other { + new line, or one line + no bracket.

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/src/date_format_...
File pkg/intl/lib/src/date_format_helpers.dart (left):

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/src/date_format_...
pkg/intl/lib/src/date_format_helpers.dart:74: Dynamic next() =>
contents[index++];
will this no longer work now?

[Alan Knight, 2012-10-31 21:31:58]

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/bidi_utils.dart
File pkg/intl/lib/bidi_utils.dart (right):

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/bidi_utils.dart#...
pkg/intl/lib/bidi_utils.dart:362: if (char == '('.charCodeAt(0)) { sum++;
On 2012/10/31 20:17:32, Emily Fortuna wrote:
> adding brackets here while sum++ is still on the same line as the if strikes
me
> as odd. I'd say do one or the other { + new line, or one line + no bracket.

Interesting. That's something the tool must have done. Reverting it.

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/src/date_format_...
File pkg/intl/lib/src/date_format_helpers.dart (left):

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/src/date_format_...
pkg/intl/lib/src/date_format_helpers.dart:74: Dynamic next() =>
contents[index++];
On 2012/10/31 20:17:32, Emily Fortuna wrote:
> will this no longer work now?

It would have to be small d dynamic. This is another editor auto-change. I think
Object will work also work. It seems to make no difference, I suspect the
explicit Dynamic was to prevent the editor from showing spurious warnings. This
is just an internal helper class, so removing the declaration altogether to be
consistent with the others. I don't get any warnings, and it all runs fine.

[scheglov, 2012-11-01 03:23:27]

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/bidi_utils.dart
File pkg/intl/lib/bidi_utils.dart (right):

https://codereview.chromium.org/11366016/diff/1/pkg/intl/lib/bidi_utils.dart#...
pkg/intl/lib/bidi_utils.dart:362: if (char == '('.charCodeAt(0)) { sum++;
On 2012/10/31 21:31:59, Alan Knight wrote:
> On 2012/10/31 20:17:32, Emily Fortuna wrote:
> > adding brackets here while sum++ is still on the same line as the if strikes
> me
> > as odd. I'd say do one or the other { + new line, or one line + no bracket.
> 
> Interesting. That's something the tool must have done. Reverting it.

You probably have some clean ups on "Style" page active.

Actually Style Guide requires to use {} here:

DO use curly braces for all flow control structures.
There is one exception to this: short if statements with no else clause that fit
on one line may omit the braces.