Issue 11365273: Upon script loading deoptimize only functions whose owner has been subclassed, as that is the only…

Issue 11365273: Upon script loading deoptimize only functions whose owner has been subclassed, as that is the only… (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
regis, Florian Schneider

CC:
reviews_dartlang.org, Kevin Millikin (Google), Vyacheslav Egorov (Chromium), Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Upon script loading deoptimize only functions whose owener has been subclassed, as that is the only CHA optimizations being applied to the code at the moment. Committed: https://code.google.com/p/dart/source/detail?r=14934

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 4

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -28 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 2	6 chunks	+56 lines, -8 lines	2 comments	Download
M	runtime/vm/code_generator.cc	View		1 chunk	+52 lines, -20 lines	2 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11365273/diff/5001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/11365273/diff/5001/runtime/vm/class_finalizer.cc#newcode131 runtime/vm/class_finalizer.cc:131: // Collect classes that are finalized superclasses of ...

8 years, 1 month ago (2012-11-15 00:29:47 UTC) #2

srdjan

https://codereview.chromium.org/11365273/diff/5001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/11365273/diff/5001/runtime/vm/class_finalizer.cc#newcode131 runtime/vm/class_finalizer.cc:131: // Collect classes that are finalized superclasses of pending ...

8 years, 1 month ago (2012-11-15 00:32:40 UTC) #3

Florian Schneider

lgtm https://codereview.chromium.org/11365273/diff/8002/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/11365273/diff/8002/runtime/vm/class_finalizer.cc#newcode36 runtime/vm/class_finalizer.cc:36: // TODO(srdjan): Be even more precise by recording ...

8 years, 1 month ago (2012-11-15 00:46:06 UTC) #4

srdjan

8 years, 1 month ago (2012-11-15 01:04:44 UTC) #5

Thanks, fixed in following CL

https://codereview.chromium.org/11365273/diff/8002/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/11365273/diff/8002/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:36: // TODO(srdjan): Be even more precise by
recording the exact CHA optimziation.
On 2012/11/15 00:46:06, Florian Schneider wrote:
> s/optimziation/optimization/

Done.

https://codereview.chromium.org/11365273/diff/8002/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11365273/diff/8002/runtime/vm/code_generator....
runtime/vm/code_generator.cc:1690: void DeoptimizeIfOwner(const
GrowableArray<intptr_t>& classes) {
On 2012/11/15 00:46:06, Florian Schneider wrote:
> It seems that DeoptimizeIfOwner is not used yet. Is it intentional?

Oops, forgot to refer to it from RemoveOptimizedCode.

Expand Messages | Collapse Messages