Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 11365203: Unmerging HTMLDocument from Document. (Closed)

Created:
8 years, 1 month ago by blois
Modified:
8 years, 1 month ago
Reviewers:
Jacob, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Unmerging HTMLDocument from Document, moving appropriate methods from Document to HTMLDocument, fixing issues around Document not being correctly wrapped for some XMLDocuments. BUG=6453, 3420, 2977, 5526 Committed: https://code.google.com/p/dart/source/detail?r=14996

Patch Set 1 #

Patch Set 2 : Fixing extra whitespace. #

Patch Set 3 : Try #2. #

Total comments: 2

Patch Set 4 : Merging to head. #

Patch Set 5 : Syncing to head. #

Patch Set 6 : Syncing to latest. #

Patch Set 7 : Try again? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -131 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 9 chunks +112 lines, -28 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 25 chunks +133 lines, -77 lines 0 comments Download
M sdk/lib/html/idl/dart/dart.idl View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/scripts/generator.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
sdk/lib/html/scripts/htmlrenamer.py View 1 2 3 6 chunks +30 lines, -5 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 1 2 3 1 chunk +11 lines, -12 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Document.darttemplate View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
A sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate View 1 chunk +82 lines, -0 lines 0 comments Download
A tests/html/xmldocument_2_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
8 years, 1 month ago (2012-11-12 18:38:20 UTC) #1
blois
On 2012/11/12 18:38:20, blois wrote: Note that I referenced a few bugs which we have ...
8 years, 1 month ago (2012-11-15 01:05:25 UTC) #2
Jacob
https://chromiumcodereview.appspot.com/11365203/diff/5001/sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate File sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate (right): https://chromiumcodereview.appspot.com/11365203/diff/5001/sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate#newcode33 sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate:33: String get lastModified => document.$dom_lastModified; why do these have ...
8 years, 1 month ago (2012-11-15 18:09:54 UTC) #3
blois
https://chromiumcodereview.appspot.com/11365203/diff/5001/sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate File sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate (right): https://chromiumcodereview.appspot.com/11365203/diff/5001/sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate#newcode33 sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate:33: String get lastModified => document.$dom_lastModified; On 2012/11/15 18:09:54, Jacob ...
8 years, 1 month ago (2012-11-15 18:24:13 UTC) #4
Jacob
8 years, 1 month ago (2012-11-15 18:54:47 UTC) #5
On 2012/11/15 18:24:13, blois wrote:
>
https://chromiumcodereview.appspot.com/11365203/diff/5001/sdk/lib/html/templa...
> File sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate (right):
> 
>
https://chromiumcodereview.appspot.com/11365203/diff/5001/sdk/lib/html/templa...
> sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate:33: String get
> lastModified => document.$dom_lastModified;
> On 2012/11/15 18:09:54, Jacob wrote:
> > why do these have to be manually listed in the template? 
> > 
> > I'm missing what is custom about these methods.
> 
> These are all methods which in WebKit are declared on Document, but really
> should be on HtmlDocument.
> 
> A few of our most voted on bugs are around fixing Document for XML uses, so
I'm
> looking to clean up the Document interface.
> 
> I tried a couple of approaches of moving the methods from Document to
> HtmlDocument (including modifying the IDL) but ran into problems everywhere.
> This was finally the approach suggested by Vijay which works.

lgtm.  shame the idl approach didn't work.

Powered by Google App Engine
This is Rietveld 408576698