Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 11365179: Fix Code::ToCString. (Closed)

Created:
8 years, 1 month ago by Kevin Millikin (Google)
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Code::ToCString. It was printing the entry address in decimal and only the low 32 bits on x64. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
8 years, 1 month ago (2012-11-09 19:39:58 UTC) #1
Vyacheslav Egorov (Google)
8 years, 1 month ago (2012-11-09 19:41:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698