Issue 11365165: Change names of all NSS gyp targets, so they don't conflict with the Chromium target names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365165: Change names of all NSS gyp targets, so they don't conflict with the Chromium target names. (Closed)

Created:
8 years, 1 month ago by Bill Hesse

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change names of all NSS gyp targets, so they don't conflict with the Chromium target names. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14731

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -39 lines)			Patch
M	runtime/bin/bin.gypi	View	2 chunks	+16 lines, -16 lines	1 comment	Download
M	runtime/bin/net/nss.gyp	View	7 chunks	+13 lines, -13 lines	0 comments	Download
M	runtime/bin/net/sqlite.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/net/ssl.gyp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/bin/net/zlib.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

TBR=ager@google.com. Small fix for ninja build of dartium with NSS added to dart.

8 years, 1 month ago (2012-11-09 10:57:26 UTC) #1

Mads Ager (google)

8 years, 1 month ago (2012-11-09 11:02:50 UTC) #2

LGTM

http://codereview.chromium.org/11365165/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

http://codereview.chromium.org/11365165/diff/1/runtime/bin/bin.gypi#newcode310
runtime/bin/bin.gypi:310: 'nss_runtime_target',
How about just nss_runtime?

Expand Messages | Collapse Messages