Issue 11365132: Fix the build: we must still not mangle parameter names of native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365132: Fix the build: we must still not mangle parameter names of native methods. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix the build: we must still not mangle parameter names of native methods. Committed: https://code.google.com/p/dart/source/detail?r=14629

Patch Set 1 : #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

8 years, 1 month ago (2012-11-07 16:44:30 UTC) #2

LGTM. Maybe follow up with Stephen and Erik.

https://codereview.chromium.org/11365132/diff/3/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart
(right):

https://codereview.chromium.org/11365132/diff/3/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart:514: //
The dom/html libraries have inline JS code that reference
remove tab.

Expand Messages | Collapse Messages