Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 11365108: Implement redirecting constructors. (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Implement redirecting constructors. Committed: https://code.google.com/p/dart/source/detail?r=14630

Patch Set 1 : #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Limit scope of implementation #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -21 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 2 3 3 chunks +27 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 1 chunk +29 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M dart/tests/language/language.status View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
A dart/tests/language/redirecting_factory_infinite_steps_test.dart View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
Currently running co19 tests. I know at least one test will start passing.
8 years, 1 month ago (2012-11-06 15:07:14 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/11365108/diff/3007/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart File dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11365108/diff/3007/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode1106 dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart:1106: * this is an interface constructor, [defaultImplementation] will ...
8 years, 1 month ago (2012-11-07 08:15:39 UTC) #2
ahe
Thank you for taking a look. I have uploaded substantial changes, PTAL. https://codereview.chromium.org/11365108/diff/3007/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart File dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart ...
8 years, 1 month ago (2012-11-07 14:22:16 UTC) #3
Johnni Winther
8 years, 1 month ago (2012-11-07 15:06:33 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698