Issue 11365059: Temporarily reintroduce IndexOutOfRangeError matcher in unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365059: Temporarily reintroduce IndexOutOfRangeError matcher in unittests. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Temporarily reintroduce IndexOutOfRangeError matcher in unittests. For even more backwards compatibility, don't remove the matcher yet. Also change inheritance structure to make catching RangeError with "on IndexOutOfRangeException" work. Committed: https://code.google.com/p/dart/source/detail?r=14456

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added consts. #

Patch Set 3 : Correct syntax. #

Patch Set 4 : Fixed test expectations now that we are 100% backwards compatible. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -70 lines)			Patch
M	lib/core/errors.dart	View	1 2 3	3 chunks	+13 lines, -10 lines	0 comments	Download
M	pkg/unittest/lib/src/core_matchers.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2 3	1 chunk	+0 lines, -20 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3	1 chunk	+0 lines, -20 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm Maybe open a bug on removing this? https://codereview.chromium.org/11365059/diff/1/lib/core/errors.dart File lib/core/errors.dart (right): https://codereview.chromium.org/11365059/diff/1/lib/core/errors.dart#newcode67 lib/core/errors.dart:67: interface ...

8 years, 1 month ago (2012-11-02 08:14:57 UTC) #2

Lasse Reichstein Nielsen

8 years, 1 month ago (2012-11-02 08:20:29 UTC) #3

I'll add a bug to remove this again.

https://codereview.chromium.org/11365059/diff/1/lib/core/errors.dart
File lib/core/errors.dart (right):

https://codereview.chromium.org/11365059/diff/1/lib/core/errors.dart#newcode67
lib/core/errors.dart:67: interface IndexOutOfRangeException implements Exception
default RangeError {
Yes. Redirecting factory constructors don't work yet in dart2js, so I have to
use an interface (because it should be const, which I'll add!).

Expand Messages | Collapse Messages