Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 11365030: Fix issue 6452: do not change a dynamic setter call to a field set in case the field is not assigna… (Closed)

Created:
8 years, 1 month ago by ngeoffray
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 6452: do not change a dynamic setter call to a field set in case the field is not assignable. Committed: https://code.google.com/p/dart/source/detail?r=14393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M lib/compiler/implementation/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
8 years, 1 month ago (2012-11-01 10:50:41 UTC) #1
kasperl
LGTM.
8 years, 1 month ago (2012-11-01 11:16:53 UTC) #2
karlklose
8 years, 1 month ago (2012-11-01 11:21:07 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698