Issue 11364232: Fix file test to test for both decomposed and precomposed utf16

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11364232: Fix file test to test for both decomposed and precomposed utf16 (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix file test to test for both decomposed and precomposed utf16 form. MacOS system calls gives you the decomposed form and the VM strings are in the precomposed form. Attempt to enable the process too which does not fail on my machine. I'd like to have a look at the failure on the buildbot to diagnose if it still fails. R=sgjesse@google.com BUG=dartbug.com/6702 Committed: https://code.google.com/p/dart/source/detail?r=14891

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove xcode configuration changes #

Patch Set 3 : Merging in changes #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -16 lines)			Patch
M	tests/standalone/io/directory_non_ascii_sync_test.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	tests/standalone/io/directory_non_ascii_test.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	tests/standalone/io/file_non_ascii_sync_test.dart	View		1 chunk	+11 lines, -3 lines	0 comments	Download
M	tests/standalone/io/file_non_ascii_test.dart	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

https://codereview.chromium.org/11364232/diff/1/tools/gyp/configurations_xcode.gypi File tools/gyp/configurations_xcode.gypi (right): https://codereview.chromium.org/11364232/diff/1/tools/gyp/configurations_xcode.gypi#newcode15 tools/gyp/configurations_xcode.gypi:15: 'variables': { Please ignore this file. The changes belong ...

8 years, 1 month ago (2012-11-14 13:19:55 UTC) #2

lgtm

Expand Messages | Collapse Messages