Issue 11364222: Improve SHR by using range information for the shift count.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11364222: Improve SHR by using range information for the shift count. (Closed)

Created:
8 years, 1 month ago by Florian Schneider

Modified:
8 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve SHR by using range information for the shift count. Avoid emitting unnecessary range checks for the shift count if the value is known to be positive and/or less than the max shift count. Committed: https://code.google.com/p/dart/source/detail?r=14864

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -20 lines)			Patch
M	runtime/vm/intermediate_language.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+15 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages