Dartifying SVG library class names.

Dartifying SVG library class names.

This CL is based on my previous CL to split out the SVG library.

Basically it renames most classes, but because of some name conflicts around Element and Document, I've skipped those. Renaming those classes will require some sizable changes to the generation code to emit library prefixes when referencing types across libs.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15107

[Anton Muhin, 2012-11-13 11:37:19]

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:286: def RenameIDLName(self, name):
why this indirection?

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
do you really need [0-9] here?

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
this mix of [A-Z]* and [A-Z], how does it work?

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
if all you want is to change a sequence of caps into Cc...cC, there are
apparently simpler approaches like

def toLower(match):
  s = match.group(0)
  return s[0] + s[1:-2].lower() + s[-1]

return re.sub(r"[A-Z]+", toLower, name)

[blois, 2012-11-14 17:21:50]

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:286: def RenameIDLName(self, name):
On 2012/11/13 11:37:19, Anton Muhin wrote:
> why this indirection?
I wanted to be explicit that normally RenameInterface should be used.

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
On 2012/11/13 11:37:19, Anton Muhin wrote:
> do you really need [0-9] here?
This catches cases such as 2D and 3D which should become 2d.

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
On 2012/11/13 11:37:19, Anton Muhin wrote:
> this mix of [A-Z]* and [A-Z], how does it work?
Added comments to the code.

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
On 2012/11/13 11:37:19, Anton Muhin wrote:
> if all you want is to change a sequence of caps into Cc...cC, there are
> apparently simpler approaches like
> 
> def toLower(match):
>   s = match.group(0)
>   return s[0] + s[1:-2].lower() + s[-1]
> 
> return re.sub(r"[A-Z]+", toLower, name)

I cleaned up the toLower code, makes it a bit more clear what it's doing.

Your sample doesn't work on cases like IFrameElement which should be unchanged.

[sra1, 2012-11-15 01:10:10]

lgtm

https://codereview.chromium.org/11364186/diff/9001/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/9001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:348: name = type_name[3:]
Do you think there is anything in SVG that does not begin with SVG?  i.e. should
there be a check?

[blois, 2012-11-15 01:17:07]

https://codereview.chromium.org/11364186/diff/9001/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/9001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:348: name = type_name[3:]
On 2012/11/15 01:10:11, sra1 wrote:
> Do you think there is anything in SVG that does not begin with SVG?  i.e.
should
> there be a check?

I had simplified it when only dealing with SVG types, but probably too much.
Updated.

[Anton Muhin, 2012-11-15 12:11:47]

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:286: def RenameIDLName(self, name):
On 2012/11/14 17:21:50, blois wrote:
> On 2012/11/13 11:37:19, Anton Muhin wrote:
> > why this indirection?
> I wanted to be explicit that normally RenameInterface should be used.

I am not sure it is worth the complication.  DartifyTypeName looks like very
clean semantics to me

https://codereview.chromium.org/11364186/diff/5001/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:354: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
Thanks for explanation

On 2012/11/14 17:21:50, blois wrote:
> On 2012/11/13 11:37:19, Anton Muhin wrote:
> > do you really need [0-9] here?
> This catches cases such as 2D and 3D which should become 2d.

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:353: # We're looking for a sequence of
letters which start with capitol letter
nit: capit<A>l?  here and below

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:360: #   XPathNSResolver:
XPath(N)(S)(R)esolver
actually also (X)()(P)ath... and (I)()(F)

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:362: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
still I do not understand if in group(2) [A-Z]+ can match more than a single
letter.  If not, let's simplify the regexp.

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:362: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
I am not sure anyone will like it, but technically there is another option:

re.sub('(?<=[A-Z]|[0-9])[A-Z]*(?=[A-Z]|$)', lambda m: m.group(0).lower(), name)

[blois, 2012-11-15 17:30:07]

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:353: # We're looking for a sequence of
letters which start with capitol letter
On 2012/11/15 12:11:47, Anton Muhin wrote:
> nit: capit<A>l?  here and below

Done.

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:360: #   XPathNSResolver:
XPath(N)(S)(R)esolver
On 2012/11/15 12:11:47, Anton Muhin wrote:
> actually also (X)()(P)ath... and (I)()(F)

Done.

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:362: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
On 2012/11/15 12:11:47, Anton Muhin wrote:
> still I do not understand if in group(2) [A-Z]+ can match more than a single
> letter.  If not, let's simplify the regexp.

Good point, done.

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:362: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
On 2012/11/15 12:11:47, Anton Muhin wrote:
> I am not sure anyone will like it, but technically there is another option:
> 
> re.sub('(?<=[A-Z]|[0-9])[A-Z]*(?=[A-Z]|$)', lambda m: m.group(0).lower(),
name)

That does work though I find it a bit less readable. Would prefer the expanded
version.

[Anton Muhin, 2012-11-15 17:49:23]

lgtm

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/7002/sdk/lib/html/scripts/htmlr...
sdk/lib/html/scripts/htmlrenamer.py:362: return
re.sub(r"([A-Z]|[0-9])([A-Z]*)([A-Z]+|$)", toLower, name)
Up to you, Pete

On 2012/11/15 17:30:07, blois wrote:
> On 2012/11/15 12:11:47, Anton Muhin wrote:
> > I am not sure anyone will like it, but technically there is another option:
> > 
> > re.sub('(?<=[A-Z]|[0-9])[A-Z]*(?=[A-Z]|$)', lambda m: m.group(0).lower(),
> name)
> 
> That does work though I find it a bit less readable. Would prefer the expanded
> version.

https://codereview.chromium.org/11364186/diff/14001/sdk/lib/html/scripts/html...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11364186/diff/14001/sdk/lib/html/scripts/html...
sdk/lib/html/scripts/htmlrenamer.py:350: #   XPathNSResolver:
X()Path(N)(S)(R)esolver
nit: you may want to put (X) and (P) to match three groups of the next match.