Issue 11364184: Remove unused/not working function tracing flag and functionality.

Issue 11364184: Remove unused/not working function tracing flag and functionality. (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove unused/not working function tracing flag and functionality. Other small fixes, use stub to call optimization of a function (in preparation for reoptimization). Committed: https://code.google.com/p/dart/source/detail?r=14756

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -95 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	3 chunks	+13 lines, -24 lines	2 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	3 chunks	+13 lines, -24 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/11364184/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/11364184/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode38 runtime/vm/intermediate_language_ia32.cc:38: new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall); Make sure that marking ...

8 years, 1 month ago (2012-11-09 20:41:35 UTC) #2

srdjan

8 years, 1 month ago (2012-11-09 20:54:31 UTC) #3

https://codereview.chromium.org/11364184/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11364184/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:38: new LocationSummary(kNumInputs,
kNumTemps, LocationSummary::kCall);
On 2012/11/09 20:41:35, Florian Schneider wrote:
> Make sure that marking this as kCall does not cause any additional spills in
> optimized code. Maybe marking it as kNoCall would be ok, since the call only
> occurs in non-optimized code.

Discussed off-line: nothing should survice a return instruction, register spill
should not be a problem. ReturnInstr is marked as call in order to create a
pointermap when calling into runtime.

Expand Messages | Collapse Messages