Issue 11364175: Cleanup how we query for interceptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11364175: Cleanup how we query for interceptors. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup how we query for interceptors. Committed: https://code.google.com/p/dart/source/detail?r=14732

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -42 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	6 chunks	+25 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/11364175/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11364175/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode58 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:58: String mangledName = selector.name.slowToString(); You could store selector.name.slowToString ...

8 years, 1 month ago (2012-11-09 11:14:36 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-09 11:17:54 UTC) #3

Thanks Karl

https://codereview.chromium.org/11364175/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11364175/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:58: String
mangledName = selector.name.slowToString();
On 2012/11/09 11:14:36, karlklose wrote:
> You could store selector.name.slowToString in a local variable at the
beginning
> of the method.

Done.

Expand Messages | Collapse Messages

Issue 11364175: Cleanup how we query for interceptors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages