Issue 11364141: Pass absolute path to git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11364141: Pass absolute path to git. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom

Modified:
8 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Pass absolute path to git. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14670

Patch Set 3 : Espace backslash in regex. #

Patch Set 5 : Clean up some merge bugs. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
M	utils/pub/git_source.dart	View	2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	utils/pub/io.dart	View	1 2 3 4	2 chunks	+21 lines, -7 lines	0 comments	Download
M	utils/pub/pub.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

One question, otherwise LGTM https://codereview.chromium.org/11364141/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11364141/diff/1/utils/pub/io.dart#newcode385 utils/pub/io.dart:385: const ABSOLUTE = const RegExp(r'^(\\|[a-zA-Z]:[/\\])'); ...

8 years, 1 month ago (2012-11-08 00:23:30 UTC) #2

Bob Nystrom

8 years, 1 month ago (2012-11-08 00:25:18 UTC) #3

https://codereview.chromium.org/11364141/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11364141/diff/1/utils/pub/io.dart#newcode385
utils/pub/io.dart:385: const ABSOLUTE = const RegExp(r'^(\\|[a-zA-Z]:[/\\])');
On 2012/11/08 00:23:30, nweiz wrote:
> Doesn't the first branch of this match only only leading backslash?

It's a raw string, so it should be two, I think.

Expand Messages | Collapse Messages

Issue 11364141: Pass absolute path to git. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Espace backslash in regex. #

Patch Set 4 : Rebase. #

Patch Set 5 : Clean up some merge bugs. #

Messages