Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 11364122: Do *not* report connection reset by peer as an error on an http server (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)
Modified:
8 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do *not* report connection reset by peer as an error on an http server when no request is in progress. Instead treat it as a normal close of the connection. This error was introduced yesterday when getting rid of the connection memory leak. Handling the connection errors as a normal close still makes sure to clean up so we do not leak memory. R=sgjesse@google.com BUG=dartbug.com/6585 Committed: https://code.google.com/p/dart/source/detail?r=14617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M sdk/lib/io/http_impl.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 8 chunks +36 lines, -10 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 1 month ago (2012-11-07 10:22:49 UTC) #1
Søren Gjesse
8 years, 1 month ago (2012-11-07 10:32:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698