Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 11364025: Remove dependency on dart:json. (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years, 1 month ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, podivilov1
Visibility:
Public.

Description

Remove dependency on dart:json. Committed: https://code.google.com/p/dart/source/detail?r=14790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -52 lines) Patch
M dart/lib/compiler/implementation/js_backend/constant_emitter.dart View 1 chunk +5 lines, -44 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/scanner_task.dart View 1 chunk +7 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/source_map_builder.dart View 3 chunks +19 lines, -7 lines 0 comments Download
M dart/lib/compiler/implementation/util/util.dart View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 1 month ago (2012-11-01 13:00:28 UTC) #1
ahe
Nicolas, could you take a look. Johnni is not available today.
8 years, 1 month ago (2012-11-12 08:48:17 UTC) #2
ngeoffray
LGTM
8 years, 1 month ago (2012-11-12 08:59:15 UTC) #3
ahe
8 years, 1 month ago (2012-11-12 14:00:29 UTC) #4
Thank you for the review!

Powered by Google App Engine
This is Rietveld 408576698