Issue 11363249: Fix error reporting on invalid command line args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11363249: Fix error reporting on invalid command line args. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom

Modified:
8 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix error reporting on invalid command line args. It would crash in a few cases if you didn't pass in a valid command Also fixed a few unrelated warnings since a warning we learned to ignore was masking the original issue. :( Committed: https://code.google.com/p/dart/source/detail?r=14927

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -31 lines)			Patch
M	utils/pub/command_help.dart	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	utils/pub/command_version.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	utils/pub/pub.dart	View	6 chunks	+11 lines, -8 lines	0 comments	Download
M	utils/pub/source.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/pub/version_solver.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View	2 chunks	+37 lines, -10 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	utils/tests/pub/version_solver_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Fixes dartbug.com/6712, but is also just generally nicer.

8 years, 1 month ago (2012-11-14 22:55:16 UTC) #1

lgtm

Expand Messages | Collapse Messages