Issue 11363154: Rearange the mock.dart comments for better doc formatting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11363154: Rearange the mock.dart comments for better doc formatting. (Closed)

Created:
8 years, 1 month ago by gram

Modified:
8 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Rearange the mock.dart comments for better doc formatting. Committed: https://code.google.com/p/dart/source/detail?r=14749

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -83 lines)			Patch
	M	pkg/unittest/lib/mock.dart	View		2 chunks	+84 lines, -83 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 1 month ago (2012-11-09 03:23:31 UTC) #2

lgtm

https://codereview.chromium.org/11363154/diff/1/pkg/unittest/lib/mock.dart
File pkg/unittest/lib/mock.dart (right):

https://codereview.chromium.org/11363154/diff/1/pkg/unittest/lib/mock.dart#ne...
pkg/unittest/lib/mock.dart:41: * - only positional parameters are supported (up
to 10);
Not sure if this will render correctly as a list, maybe you need to put an extra
empty line, and use *?

Expand Messages | Collapse Messages